Make Example Projects Standalone #74
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…more easily used as an example
… used as an example
…easily used as an example
|
@opticyclic do you mind if we wait until after the release of V1.0 for this? That will be in a week or two. Reluctant to change so much stuff just before we release! Cheers |
|
@opticyclic Accounts 1.0 should be released this week. We'll merge your PR after. Cheers! |
|
Is it possible to merge now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows on from #53 addressing #46 to make the example projects standalone so they can be used as a sample base for new accounts based projects.
The pull request has been re-done because there have been several changes making the merge of the original very difficult.
Interestingly, the sweepstake code would not compile once the project was made standalone as non-public APIs were being used so a minor change was required to the code and not just the build files.