Skip to content

Commit

Permalink
CORE-17816 signatory signatures verification for contract verifying i…
Browse files Browse the repository at this point in the history
…mplementation (#1421)

Exposed verifySignatorySignatures() to public in order to use in verifying notary server
  • Loading branch information
jennyang-r3 authored Dec 21, 2023
1 parent c6d34bb commit 8310e5b
Show file tree
Hide file tree
Showing 4 changed files with 19 additions and 5 deletions.
6 changes: 3 additions & 3 deletions application/scans/corda-application-5.2.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -1463,7 +1463,7 @@ net.corda.v5.application.messaging.FlowSession:
type: Object
net.corda.v5.application.messaging.FlowSessionConfiguration:
annotations: []
type: public class
type: public final class
extends: null
implements: []
interface: false
Expand All @@ -1480,7 +1480,7 @@ net.corda.v5.application.messaging.FlowSessionConfiguration:
returnType: boolean
net.corda.v5.application.messaging.FlowSessionConfiguration$Builder:
annotations: []
type: public static class
type: public static final class
extends: null
implements: []
interface: false
Expand Down Expand Up @@ -1619,7 +1619,7 @@ net.corda.v5.application.persistence.ParameterizedQuery:
type: String
value:
annotation:
- NotNull
- Nullable
type: Object
setParameters:
annotations:
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ cordaProductVersion = 5.2.0
# NOTE: update this each time this module contains a breaking change
## NOTE: currently this is a top level revision, so all API versions will line up, but this could be moved to
## a per module property in which case module versions can change independently.
cordaApiRevision = 22
cordaApiRevision = 23

# Main
kotlin.stdlib.default.dependency = false
Expand Down
7 changes: 6 additions & 1 deletion ledger/ledger-utxo/scans/corda-ledger-utxo-5.2.0.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ net.corda.v5.ledger.utxo.query.VaultNamedParameterizedQuery:
type: String
value:
annotation:
- NotNull
- Nullable
type: Object
setParameters:
annotations:
Expand Down Expand Up @@ -1670,6 +1670,11 @@ net.corda.v5.ledger.utxo.transaction.UtxoSignedTransaction:
referenceStateAndRefs:
annotation: []
type: java.util.List<net.corda.v5.ledger.utxo.StateAndRef<?>>
verifySignatorySignatures:
annotations: []
default: false
type: public abstract
returnType: void
net.corda.v5.ledger.utxo.transaction.UtxoTransactionBuilder:
annotations:
- DoNotImplement
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
import net.corda.v5.base.annotations.DoNotImplement;
import net.corda.v5.base.annotations.Suspendable;
import net.corda.v5.base.types.MemberX500Name;
import net.corda.v5.ledger.common.transaction.TransactionSignatureException;
import net.corda.v5.ledger.common.transaction.TransactionWithMetadata;
import net.corda.v5.ledger.utxo.Command;
import net.corda.v5.ledger.utxo.StateAndRef;
Expand Down Expand Up @@ -132,4 +133,12 @@ public interface UtxoSignedTransaction extends TransactionWithMetadata {
@NotNull
@Suspendable
UtxoLedgerTransaction toLedgerTransaction(List<StateAndRef<?>> inputStateAndRefs, List<StateAndRef<?>> referenceStateAndRefs);

/**
* Verify the signatories' signatures and check if there are any missing one.
* It ignores the non-signatory signatures! (including the notary's)
*
* @throws TransactionSignatureException if any signatures are missing or invalid.
*/
void verifySignatorySignatures();
}

0 comments on commit 8310e5b

Please sign in to comment.