CORE-13119 Add resumePoint Avro field to support stable query paging
#1229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
relyafi
changed the title
sequence_num primary key on utxo_visible_transaction_statessequence_num primary key on utxo_visible_transaction_states
vlajos
reviewed
Aug 30, 2023
...a/src/main/resources/net/corda/db/schema/vnode-vault/migration/ledger-utxo-creation-v5.1.xml
Outdated
Show resolved
Hide resolved
relyafi
force-pushed
the
ramzi/core-13119/custom-query-stable-paging
branch
from
d0cfa15 to
6399a7b
Compare
relyafi
changed the title
sequence_num primary key on utxo_visible_transaction_statesresumePoint Avro field to support stable query paging
|
Jenkins build for PR 1229 build 4 Build Successful: |
vlajos
approved these changes
Sep 15, 2023
nkovacsx
approved these changes
Sep 18, 2023
driessamyn
reviewed
Sep 18, 2023
| { | ||
| "name": "resumePoint", | ||
| "doc": "Used by queries that support stable paging to return opaque data that indicates where the next page should resume from", | ||
| "type": ["null", "bytes"], |
There was a problem hiding this comment.
Why is this a byte array rather than a structured type?
There was a problem hiding this comment.
We don't want to be opinionated on the contents of the field, it could vary from query to query - the data is opaque from the perspective of the interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pre-requisite change to enable a
resumePointfield to be passed back and forth between ledger custom queries initiated in a flow processor and the query execution logic in a ledger persistence processor.See corda/corda-runtime-os#4548 for full details of the changes.