Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-9975: Add support for key category parameter to signing API #1239

Merged
merged 5 commits into from
Sep 19, 2023

Conversation

malachyb
Copy link
Contributor

@malachyb malachyb commented Sep 6, 2023

Added support for context parameter as a map<string, string> to signing API.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

@malachyb malachyb changed the title Malachy/core 9975 e2e tests CORE-9975: Add support for key category parameter to signing API Sep 6, 2023
@github-actions github-actions bot dismissed their stale review September 6, 2023 15:51

All good!

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 8, 2023

Jenkins build for PR 1239 build 9

Build Successful:
Jar artifact version produced by this PR: 5.1.0.20-alpha-1695114203902

@malachyb malachyb force-pushed the malachy/CORE-9975-e2eTests branch from 250811d to 508dd8f Compare September 11, 2023 14:37
@malachyb malachyb force-pushed the malachy/CORE-9975-e2eTests branch from a5f9dff to ea9b643 Compare September 13, 2023 09:44
@malachyb malachyb marked this pull request as ready for review September 13, 2023 09:57
@malachyb malachyb requested a review from a team as a code owner September 13, 2023 09:57
Copy link
Contributor

@dickon dickon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. SInce we are adding a new overload method this should be fully compatible.

Copy link
Contributor

@davidcurrie davidcurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@malachyb malachyb merged commit 1e2c46c into release/os/5.1 Sep 19, 2023
@malachyb malachyb deleted the malachy/CORE-9975-e2eTests branch September 19, 2023 09:47
@malachyb malachyb restored the malachy/CORE-9975-e2eTests branch September 19, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants