Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-13620 Idempotency id table housekeeping #1249

Merged

Conversation

kyriathar
Copy link

@kyriathar kyriathar commented Sep 15, 2023

Introduces the api bits needed to introduce the housekeeping functionality for idempotency id table (deduplication table):

  • adds a timestamp column to hold when a request id was inserted so we can delete old ones.
  • adds a dedicated topic to call the housekeeping functionality through the Scheduler.

runtime-os PR: corda/corda-runtime-os#4653

@kyriathar kyriathar changed the base branch from release/os/5.1 to kyriakos/CORE-13621-idemopotency-id-table September 15, 2023 06:44
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 15, 2023

Jenkins build for PR 1249 build 9

Build Successful:
Jar artifact version produced by this PR: 5.1.0.20-alpha-1695214982425

@kyriathar kyriathar force-pushed the kyriakos/CORE-13621-idemopotency-id-table branch from 77afe26 to f3c1624 Compare September 19, 2023 20:46
@kyriathar kyriathar force-pushed the kyriakos/CORE-13620-idempotency-id-table-housekeeping branch from 7d133df to b77b142 Compare September 20, 2023 12:10
davidcurrie
davidcurrie previously approved these changes Sep 20, 2023
Copy link
Contributor

@davidcurrie davidcurrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from kyriakos/CORE-13621-idemopotency-id-table to release/os/5.1 September 20, 2023 12:46
@kyriathar kyriathar dismissed stale reviews from davidcurrie and simon-johnson-r3 September 20, 2023 12:46

The base branch was changed.

@kyriathar kyriathar force-pushed the kyriakos/CORE-13620-idempotency-id-table-housekeeping branch from b77b142 to 5b60fbe Compare September 20, 2023 13:02
@kyriathar kyriathar merged commit e5b00ed into release/os/5.1 Sep 21, 2023
@kyriathar kyriathar deleted the kyriakos/CORE-13620-idempotency-id-table-housekeeping branch September 21, 2023 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants