CORE-16860 counterparty info refactor #1256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 1256 build 5 Build Successful: |
| @@ -11,7 +11,6 @@ | |||
| "name": "payload", | |||
| "type": [ | |||
| "net.corda.data.flow.event.StartFlow", | |||
| "net.corda.data.flow.event.Wakeup", | |||
There was a problem hiding this comment.
It's a remote edge case, but removing types like this could be a problem when upgrading from 5.0 to 5.1, need to check with @simon-johnson-r3, also worth adding an avro upgrade test to validate the change (see existing tests for an example)
There was a problem hiding this comment.
I think upgrade guarantees are just that you won't need to recompile your application. In particular I don't think we're guaranteeing that in flight flows will work across an upgrade, so any events of these types present in the system will need to be cleared before the upgrade can go ahead.
| @@ -50,8 +50,8 @@ | |||
| { | |||
| "name": "payload", | |||
| "type": [ | |||
| "net.corda.data.flow.event.session.SessionInit", | |||
conalsmith-r3
approved these changes
Sep 21, 2023
JamesHR3
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To request counterparty info when it has not already been exchanged, send a SessionCounterpartyInfoRQ.
Include SessionInit payload to start the remote flow.
If data has already been exchanged SessionCounterpartyInfoRQ wont be sent.
Respond with SessionCounterpartyInfoRS session event payload. Blank fields as contextSessionProperties are set on SessionEvent
SequenceNumber will be set to null for both payload types. Only SessionData and SessionClose payloads will have sequence numbers set on SessionEvent