CORE-17257 - Reason column length is too short in RegistrationRequest table #1257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yift-r3
reviewed
Sep 21, 2023
|
|
||
| <modifyDataType | ||
| columnName="reason" | ||
| newDataType="varchar(1000)" |
There was a problem hiding this comment.
Maybe we should change it to TEXT?
(If we do keep it as varchar, we need to add a code to trim the reason in the runtime code)
There was a problem hiding this comment.
I think you are right. Text is better suited for long messages and we possibly have lengthy reasons at times.
|
Jenkins build for PR 1257 build 2 Build Successful: |
yift-r3
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resiliency test run failed caused by exception messages found in db worker logs. The exception messages suggested that the previous length of 255 was too short for the reason column.