CORE-15396 Add support for an expiry timeout on a token claim #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| { | ||
| "name": "claimTimestamp", | ||
| "type": ["null", "long"], | ||
| "default": null, |
There was a problem hiding this comment.
What does it mean if a claim does not have a timestamp? Will a claim with no timestamp ever expire?
There was a problem hiding this comment.
in the runtime-os change that uses this, if it finds a old 5.0 version state it defaults the timestamp to the current time.
owenstanford
force-pushed
the
owen/CORE-6803-Token-claim-timeout
branch
from
3d0362d to
4a53e54
Compare
…s to support automatic cleanup of orphaned claims.
owenstanford
force-pushed
the
owen/CORE-6803-Token-claim-timeout
branch
from
4a53e54 to
d1e75cb
Compare
|
Jenkins build for PR 1259 build 5 Build Successful: |
filipesoliveira
approved these changes
Sep 22, 2023
josephzunigadaly
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for an expiry timeout on a token claim, this is to support automatic cleanup of orphaned claims.