Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-16615: introduce new api to find an unconsumed states #1260

Merged
merged 7 commits into from
Sep 26, 2023

Conversation

jennyang-r3
Copy link
Contributor

@jennyang-r3 jennyang-r3 commented Sep 25, 2023

Overview

This PR introduces a new API that finds unconsumed states given the state type. We are introducing this function even though there is findUnconsumedStatesByType because the function uses in-memory filtering, whereas this new function uses db query index.

@jennyang-r3 jennyang-r3 marked this pull request as ready for review September 25, 2023 08:07
@jennyang-r3 jennyang-r3 requested a review from a team as a code owner September 25, 2023 08:07
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 25, 2023

Jenkins build for PR 1260 build 7

Build Successful:
Jar artifact version produced by this PR: 5.1.0.23-alpha-1695654276915

vlajos
vlajos previously approved these changes Sep 25, 2023
vlajos
vlajos previously approved these changes Sep 25, 2023
relyafi
relyafi previously approved these changes Sep 25, 2023
Copy link
Contributor

@relyafi relyafi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there's an error in the AVRO documentation.

@jennyang-r3 jennyang-r3 dismissed stale reviews from relyafi and vlajos via 0ed5580 September 25, 2023 14:07
@jennyang-r3 jennyang-r3 requested a review from blsemo September 25, 2023 14:17
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennyang-r3 jennyang-r3 merged commit e886aad into release/os/5.1 Sep 26, 2023
1 check passed
@jennyang-r3 jennyang-r3 deleted the jennyang/CORE-16615-introduce-new-api branch September 26, 2023 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants