-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-16615: introduce new api to find an unconsumed states #1260
CORE-16615: introduce new api to find an unconsumed states #1260
Conversation
Jenkins build for PR 1260 build 7 Build Successful: |
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think there's an error in the AVRO documentation.
.../main/resources/avro/net/corda/data/ledger/persistence/FindUnconsumedVisibleExactStates.avsc
Outdated
Show resolved
Hide resolved
.../kotlin/net/corda/data/ledger/persistence/LedgerPersistenceRequestSchemaCompatibilityTest.kt
Outdated
Show resolved
Hide resolved
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
This PR introduces a new API that finds unconsumed states given the state type. We are introducing this function even though there is
findUnconsumedStatesByType
because the function uses in-memory filtering, whereas this new function uses db query index.