CORE-17387 - Flow timeout events. #1272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
driessamyn
commented
Oct 2, 2023
| "doc": "Represents of a flow timeout instruction.", | ||
| "fields": [ | ||
| { | ||
| "name": "checkpointStateKey", |
There was a problem hiding this comment.
As I understand, this is the flow ID, but I thought maybe it's worth being specific in case this changes/evolves.
There was a problem hiding this comment.
Think there's no harm in having it.
driessamyn
commented
Oct 2, 2023
| "doc": "Key for the state record that is storing the checkpoint." | ||
| }, | ||
| { | ||
| "name": "timeoutDateTime", |
There was a problem hiding this comment.
This is probably not strictly necessary but may be useful when troubleshooting or monitoring the system health?
There was a problem hiding this comment.
We're not great in general at using Avro records for this sort of thing, but it does give us a chance to log at the point where we receive the event.
JamesHR3
approved these changes
Oct 2, 2023
|
Jenkins build for PR 1272 build 2 Build Successful: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Topic and Avro schema for flow timeout events.