Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-1398 Pipeline integration with corda-api scanner PR gates #1274

Merged
merged 23 commits into from
Oct 25, 2023

Conversation

jacob-scott3141
Copy link
Contributor

@jacob-scott3141 jacob-scott3141 commented Oct 3, 2023

Adds internal gradle plugin dependency and YAML files to track API changes with @tomstark99 's API Scanner

Shared pipeline changes add the following comments on Corda-API PR's:

  • On Failed Scan:
    Screenshot 2023-10-04 150333
  • On Successful Scan:
    Screenshot 2023-10-04 172634

PR Checklist:

  • Have you run the unit, integration and smoke tests as described here?
  • If you added public APIs, did you write the JavaDocs?
  • If the changes are of interest to application developers, have you added them to the changelog (/docs/source/changelog.rst), and potentially the release notes (/docs/source/release-notes.rst)?
  • If you are contributing for the first time, please read the contributor agreement now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.

Thanks for your code, it's appreciated! :)

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 4, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1274/22/ has failed for PR 1274 build 22

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 4, 2023

API Scan for PR 1274

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 4, 2023

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1274/21/ has failed for PR 1274 build 21

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 5, 2023

Jenkins build for PR 1274 build 34

Build Successful:
Jar artifact version produced by this PR: 5.1.0.37-alpha-1698230258187

@jacob-scott3141 jacob-scott3141 marked this pull request as ready for review October 5, 2023 10:52
@jacob-scott3141 jacob-scott3141 requested review from a team as code owners October 5, 2023 10:52
@jacob-scott3141 jacob-scott3141 marked this pull request as draft October 5, 2023 11:17
.ci/JenkinsApiCompatibility Outdated Show resolved Hide resolved
Jenkinsfile Outdated Show resolved Hide resolved
@jacob-scott3141 jacob-scott3141 marked this pull request as ready for review October 6, 2023 09:43
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 6, 2023

Scanning for breaking API changes introduced by this PR

Scan Succeeded

Copy link
Contributor

@driessamyn driessamyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly minor comments, and one more nit: would it be possible to include the apiDiff in the verification group and a dependency of the check task?

application/src/api/corda-application-5.1.0.yaml Outdated Show resolved Hide resolved
application/src/api/corda-application-5.1.0.yaml Outdated Show resolved Hide resolved
application/src/api/corda-application-5.1.0.yaml Outdated Show resolved Hide resolved
data/config-schema/build.gradle Outdated Show resolved Hide resolved
data/avro-schema/build.gradle Outdated Show resolved Hide resolved
data/db-schema/build.gradle Outdated Show resolved Hide resolved
data/rbac-schema/build.gradle Outdated Show resolved Hide resolved
data/topic-schema/build.gradle Outdated Show resolved Hide resolved
@jacob-scott3141 jacob-scott3141 marked this pull request as draft October 12, 2023 14:16
Copy link
Collaborator

@wzur-r3 wzur-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Gradle configuration files

Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacob-scott3141 jacob-scott3141 merged commit e6d293a into release/os/5.1 Oct 25, 2023
2 checks passed
@jacob-scott3141 jacob-scott3141 deleted the jacob/ES-1398 branch October 25, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants