-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ES-1398 Pipeline integration with corda-api scanner PR gates #1274
Conversation
Non-blocking downstream job failed for corda-e2e-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1274/22/ has failed for PR 1274 build 22 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests |
API Scan for PR 1274 Scan Succeeded |
Non-blocking downstream job failed for corda-non-functional-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1274/21/ has failed for PR 1274 build 21 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test |
Jenkins build for PR 1274 build 34 Build Successful: |
Scanning for breaking API changes introduced by this PR Scan Succeeded |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly minor comments, and one more nit: would it be possible to include the apiDiff
in the verification
group and a dependency of the check
task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for Gradle configuration files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Adds internal gradle plugin dependency and YAML files to track API changes with @tomstark99 's API Scanner
Shared pipeline changes add the following comments on Corda-API PR's:
PR Checklist:
If you added public APIs, did you write the JavaDocs?If the changes are of interest to application developers, have you added them to the changelog (/docs/source/changelog.rst
), and potentially the release notes (/docs/source/release-notes.rst
)?If you are contributing for the first time, please read the contributor agreement now and add a comment to this pull request stating that your PR is in accordance with the Developer's Certificate of Origin.Thanks for your code, it's appreciated! :)