CORE-17430 Modify the utxo_transaction_sources table by removing unused columns and renaming #1288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto nandor/CORE-17430/extra-column-backchain
|
Jenkins build for PR 1288 build 8 Build Successful: |
…nto nandor/CORE-17430/extra-column-backchain
nkovacsx
changed the title
nkovacsx
changed the title
…nto nandor/CORE-17430/extra-column-backchain
vlajos
previously approved these changes
Oct 12, 2023
…nto nandor/CORE-17430/extra-column-backchain
relyafi
reviewed
Oct 13, 2023
...a/src/main/resources/net/corda/db/schema/vnode-vault/migration/ledger-utxo-creation-v5.1.xml
Outdated
Show resolved
Hide resolved
relyafi
approved these changes
Oct 13, 2023
vlajos
approved these changes
Oct 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The
createdandis_ref_inputcolumns are unnecessary to have in theutxo_transaction_sourcestable.The created column will be the same as in utxo_transaction_component table and it’s a 1:1 mapping.
Whether a state is an input or a reference can be found out by using the groupIdx column rather than having an extra is_ref_input column.
Also rename the ref_transaction_id and ref_leaf_idx columns as those are quite confusing.
Test plan
Run the combined worker with Postgres (5.0) then build the VNode CLI plugin (5.1), run the migration that generates a SQL file. Run the SQL file in the 5.0 DB. Check that the fields are present and data was migrated properly.
Run a combined worker with Postgres (5.1) and make sure no errors during startup / e2e tests. Check the DB that transactions are actually stored and the new fields are populated.