Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-16626 Replace string UUIDs with UUID objects #1290

Merged
merged 4 commits into from
Oct 24, 2023

Conversation

ac101m
Copy link
Contributor

@ac101m ac101m commented Oct 10, 2023

Changes

  • Change type of groupId field in IntropIdentityInfo from string to UUID object.
  • Change type of groupId parameter of callFacade() in FlowMessaging from string to UUID object.
  • Bump API version to 24.

@ac101m ac101m changed the base branch from release/os/5.1 to release/interop/syntax October 10, 2023 16:13
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 10, 2023

Jenkins build for PR 1290 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0-INTEROP.24-alpha-1698084218403

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 10, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1290/2/ has failed for PR 1290 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@ac101m ac101m marked this pull request as ready for review October 10, 2023 17:03
@ac101m ac101m requested a review from a team as a code owner October 10, 2023 17:03
@dickon
Copy link
Contributor

dickon commented Oct 11, 2023

Isn't this a breaking change to the API? I don't see this aligns with https://r3-cev.atlassian.net/wiki/spaces/CB/pages/4601151665/Evolution+of+the+CorDapp+API

@szymonsztuka
Copy link

Isn't this a breaking change to the API? I don't see this aligns with https://r3-cev.atlassian.net/wiki/spaces/CB/pages/4601151665/Evolution+of+the+CorDapp+API

@dickon No API is broken as this is the feature branch never released.

@dickon
Copy link
Contributor

dickon commented Oct 11, 2023

@dickon No API is broken as this is the feature branch never released.
Ah yes, my bad, I'd missed the target of this was not a release branch, and you're right that this declaration never went into a frozen branch, please disregard my comment.

@ac101m ac101m merged commit 44b9561 into release/interop/syntax Oct 24, 2023
1 check passed
@ac101m ac101m deleted the alex/CORE-16626 branch October 24, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants