Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-17355 - Reduce number of p2p e2e sessions maintained per pair of vnodes #1307

Merged
merged 23 commits into from
Nov 15, 2023
Merged

CORE-17355 - Reduce number of p2p e2e sessions maintained per pair of vnodes #1307

merged 23 commits into from
Nov 15, 2023

Conversation

nikinagy
Copy link
Contributor

In order to increase our performance, this PR reduces number of p2p e2e sessions maintained per pair of vnodes:

  • for member <-> MGM communication reduce to 1
  • for member <-> member communication reduce to 1

@nikinagy nikinagy self-assigned this Oct 19, 2023
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 19, 2023 •
edited
Loading

Jenkins build for PR 1307 build 18

Build Successful:
Jar artifact version produced by this PR: 5.2.0.2-alpha-1700037510971

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 26, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@nikinagy nikinagy changed the base branch from nikinagy/performance-enhancement to feature/large-network-improvements November 2, 2023 16:06
@nikinagy nikinagy requested a review from a team November 2, 2023 16:42
@nikinagy nikinagy changed the base branch from feature/large-network-improvements to feature/network_5_2 November 7, 2023 14:01
nikinagy and others added 3 commits November 7, 2023 14:01
@nikinagy
revert change
b2d63a2
@charlieR3
CORE-18229 Set code owners on feature branch (#1329)
b356d32 
Set the code owners on the platform network branch to just the platform network team. Not to be merged to the 5.2 branch once it is created.
@nikinagy
Merge remote-tracking branch 'origin/feature/network_5_2' into nikina…
0a8623e 
…gy/CORE-17355

# Conflicts:
#	.github/CODEOWNERS
yift-r3
yift-r3 previously approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@yift-r3 yift-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Should we have someone from docs/product look at the descriptions?

yift-r3
yift-r3 previously approved these changes Nov 8, 2023
View reviewed changes
charlieR3 and others added 3 commits November 10, 2023 15:25
@charlieR3
Merge pull request #1333 from corda/charlie/network_5_2-merge-nov-10
bb2d022 
CORE-18278 Merge the release 5.1 branch into the network team 5.2 feature branch
@nikinagy
Merge remote-tracking branch 'origin/feature/network_5_2' into nikina…
a2c2397 
…gy/CORE-17355
@nikinagy
Merge remote-tracking branch 'origin/release/os/5.2' into nikinagy/CO…
c4711d4 
…RE-17355

# Conflicts:
#	.github/CODEOWNERS
#	gradle.properties
@nikinagy nikinagy changed the base branch from feature/network_5_2 to release/os/5.2 November 14, 2023 10:50
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 14, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1307/17/ has failed for PR 1307 build 17

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 14, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1307/14/ has failed for PR 1307 build 14

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@nikinagy nikinagy marked this pull request as ready for review November 14, 2023 14:30
@nikinagy nikinagy requested a review from a team as a code owner November 14, 2023 14:30
@nikinagy nikinagy requested a review from a team November 14, 2023 14:30
yift-r3
yift-r3 previously approved these changes Nov 14, 2023
View reviewed changes
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@nikinagy nikinagy merged commit 38848f6 into release/os/5.2 Nov 15, 2023
7 checks passed
@nikinagy nikinagy deleted the nikinagy/CORE-17355 branch November 15, 2023 09:08
dickon pushed a commit that referenced this pull request Nov 17, 2023
@nikinagy @dickon
CORE-17355 - Reduce number of p2p e2e sessions maintained per pair of…
3a2593f 
… vnodes (#1307)

In order to increase our performance, this PR reduces number of p2p e2e sessions maintained per pair of vnodes:
for member <-> MGM communication reduce to 1
for member <-> member communication reduce to 1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nadinequinr3 nadinequinr3 nadinequinr3 left review comments

@williamvigorr3 williamvigorr3 williamvigorr3 left review comments

@dimosr dimosr dimosr approved these changes

@yift-r3 yift-r3 yift-r3 left review comments

Assignees

@nikinagy nikinagy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nikinagy @dimosr @williamvigorr3 @yift-r3 @nadinequinr3 @charlieR3