CORE-17502 Added token selection worker HTTP endpoint definition. #1313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenstanford
requested review from
driessamyn,
jasonbyrner3,
dimosr,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana and
Sakpal
as code owners
|
Jenkins build for PR 1313 build 1 Build Successful: |
ben-millar
reviewed
Oct 23, 2023
| @@ -47,4 +47,5 @@ private BootConfig() { | |||
| public static final String VERIFICATION_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.verification"; | |||
| public static final String UNIQUENESS_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.uniqueness"; | |||
| public static final String PERSISTENCE_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.persistence"; | |||
| public static final String TOKEN_SELECTION_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.tokenSelection"; | |||
There was a problem hiding this comment.
Suggested change
| public static final String TOKEN_SELECTION_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.tokenSelection"; | |
| public static final String TOKEN_SELECTION_WORKER_REST_ENDPOINT = BOOT_WORKER_SERVICE + ".endpoints.token-selection"; |
I think helm will generate the service endpoint in kebab case https://github.com/corda/corda-runtime-os/blob/release/os/5.1/charts/corda-lib/templates/_helpers.tpl#L653C87-L653C114
There was a problem hiding this comment.
Sorry, no, my mistake: this is for the value only. tokenSelection is fine here provided it matches what you specify inworkers.yaml
ben-millar
approved these changes
Oct 23, 2023
owenstanford
deleted the
owen/CORE-17502-Add-token-selection-service-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes to support HTTP RPC in Token Selection:
Adds the definition for the token selection workers HTTP RPC endpoint.