Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-17972 send & receive transaction #1325

Closed
wants to merge 3 commits into from
Closed

CORE-17972 send & receive transaction #1325

wants to merge 3 commits into from

Conversation

jennyang-r3
Copy link
Contributor

@jennyang-r3 jennyang-r3 commented Nov 2, 2023 •
edited
Loading

Added APIs to UtxoLedgerService and they are:

  • sendTransaction
  • receiveTransaction

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 2, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1325/7/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 2, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1325/7/ has failed for PR 1325 build 7

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 2, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1325/7/ has failed for PR 1325 build 7

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 3, 2023 •
edited
Loading

Jenkins build for PR 1325 build 7

Build Successful:
Jar artifact version produced by this PR: 5.2.0.3-alpha-1700150191858

@jennyang-r3 jennyang-r3 changed the title CORE-17972 send & receive transaction CORE-17972 DO NOT MERGE send & receive transaction Nov 3, 2023
lankydan
lankydan reviewed Nov 7, 2023
View reviewed changes
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java Outdated Show resolved Hide resolved
ledger/ledger-utxo/src/main/java/net/corda/v5/ledger/utxo/UtxoLedgerService.java Outdated
/**
* Receives transaction from counterparty.
*
* @param session The counterparty who are connected to {@link FlowSession}.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Write this similar to the finalize docs to make it clearer, same for sendTransaction.

@jennyang-r3 jennyang-r3 requested a review from lankydan November 7, 2023 11:37
@jennyang-r3 jennyang-r3 force-pushed the jennyang/CORE-18058-send-receive-tx-flows branch from 36e3a25 to 3b74b01 Compare November 16, 2023 15:14
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jennyang-r3 jennyang-r3 marked this pull request as ready for review November 16, 2023 15:47
@jennyang-r3 jennyang-r3 changed the base branch from release/os/5.1 to release/os/5.2 November 16, 2023 15:56
@jennyang-r3 jennyang-r3 requested a review from a team as a code owner November 16, 2023 15:56
@jennyang-r3 jennyang-r3 changed the title CORE-17972 DO NOT MERGE send & receive transaction CORE-17972 send & receive transaction Nov 16, 2023
@jennyang-r3 jennyang-r3 deleted the jennyang/CORE-18058-send-receive-tx-flows branch November 16, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blsemo blsemo Awaiting requested review from blsemo blsemo is a code owner

@lankydan lankydan Awaiting requested review from lankydan

@driessamyn driessamyn Awaiting requested review from driessamyn

@jasonbyrner3 jasonbyrner3 Awaiting requested review from jasonbyrner3 jasonbyrner3 is a code owner

@dimosr dimosr Awaiting requested review from dimosr

@ronanbrowne ronanbrowne Awaiting requested review from ronanbrowne ronanbrowne is a code owner

@rick-r3 rick-r3 Awaiting requested review from rick-r3 rick-r3 is a code owner

@simon-johnson-r3 simon-johnson-r3 Awaiting requested review from simon-johnson-r3 simon-johnson-r3 is a code owner

@Omar-awad Omar-awad Awaiting requested review from Omar-awad Omar-awad is a code owner

@aditisdesai aditisdesai Awaiting requested review from aditisdesai aditisdesai is a code owner

@vinir3 vinir3 Awaiting requested review from vinir3 vinir3 is a code owner

@vkolomeyko vkolomeyko Awaiting requested review from vkolomeyko vkolomeyko is a code owner

@thiagoviana thiagoviana Awaiting requested review from thiagoviana

@Sakpal Sakpal Awaiting requested review from Sakpal Sakpal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jennyang-r3 @lankydan