CORE-18229 Set code owners on feature branch #1328
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The index in `StateRef.toString` was being formatted which added commas to the output. This created an invalid string representation of a `StateRef`, causing errors if we ever called `StateRef.parse` on the output of `StateRef.toString`. Rely on normal string concatenation instead of `MessageFormat.format` to resolve this.
charlieR3
requested review from
driessamyn,
jasonbyrner3,
dimosr,
ronanbrowne,
rick-r3,
simon-johnson-r3,
blsemo,
Omar-awad,
aditisdesai,
vinir3,
vkolomeyko,
thiagoviana and
Sakpal
as code owners
|
Kudos, SonarCloud Quality Gate passed!
|
charlieR3
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the code owners on the platform network branch to just the platform network team and merge in the latest from the release branch