Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA5-15 Recurring merge #1330

Merged
merged 4 commits into from
Nov 9, 2023
Merged

Conversation

ac101m
Copy link
Contributor

@ac101m ac101m commented Nov 8, 2023

Changes

  • Merge release/os/5.1

Info

LWogan and others added 3 commits November 2, 2023 10:06
…This string is combined with the vnode shorthash to make a key for flow mapper states records for start flow events. The flow mapper state is stored in the state storage which has a limit of 255 characters. vnode shorthash is 12 characters with an additional separator character added this adds to the max 255 (#1316)

This string is combined with the vnode shorthash to make a key for flow mapper states records for start flow events. The flow mapper state is stored in the state storage which has a limit of 255 characters. vnode shorthash is 12 characters with an additional separator character added this adds to the max 255.
The index in `StateRef.toString` was being formatted which added commas
to the output. This created an invalid string representation of a
`StateRef`, causing errors if we ever called `StateRef.parse` on the
output of `StateRef.toString`.

Rely on normal string concatenation instead of `MessageFormat.format` to
resolve this.
@ac101m ac101m requested a review from a team as a code owner November 8, 2023 13:32
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

Copy link

sonarqubecloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 8, 2023

Jenkins build for PR 1330 build 2

Build Successful:
Jar artifact version produced by this PR: 5.1.0-INTEROP.25-alpha-1699450687894

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 8, 2023

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@ac101m ac101m requested a review from szymonsztuka November 8, 2023 13:45
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 8, 2023

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/ has failed for PR 1330 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 8, 2023

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/ has failed for PR 1330 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@ac101m ac101m merged commit 522689b into release/interop/syntax Nov 9, 2023
@ac101m ac101m deleted the alex/DA5-15-recurring-merge branch November 9, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants