-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DA5-15 Recurring merge #1330
DA5-15 Recurring merge #1330
Conversation
…This string is combined with the vnode shorthash to make a key for flow mapper states records for start flow events. The flow mapper state is stored in the state storage which has a limit of 255 characters. vnode shorthash is 12 characters with an additional separator character added this adds to the max 255 (#1316) This string is combined with the vnode shorthash to make a key for flow mapper states records for start flow events. The flow mapper state is stored in the state storage which has a limit of 255 characters. vnode shorthash is 12 characters with an additional separator character added this adds to the max 255.
The index in `StateRef.toString` was being formatted which added commas to the output. This created an invalid string representation of a `StateRef`, causing errors if we ever called `StateRef.parse` on the output of `StateRef.toString`. Rely on normal string concatenation instead of `MessageFormat.format` to resolve this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)
Kudos, SonarCloud Quality Gate passed!
|
Jenkins build for PR 1330 build 2 Build Successful: |
Scanning for breaking API changes introduced by this PR Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/ If the breaking changes are intentional, run |
Non-blocking downstream job failed for corda-non-functional-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/ has failed for PR 1330 build 2 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test |
Non-blocking downstream job failed for corda-e2e-test https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1330/2/ has failed for PR 1330 build 2 Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests |
Changes
release/os/5.1
Info