Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-1620: Add scans to CODEOWNERS #1334

Merged
merged 1 commit into from
Nov 14, 2023
Merged

ES-1620: Add scans to CODEOWNERS #1334

merged 1 commit into from
Nov 14, 2023

Conversation

jacob-scott3141
Copy link
Contributor

Re-add all /scans/*.yaml to CODEOWNERS for API scan PR gate

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@jacob-scott3141 jacob-scott3141 changed the title Add scans to CODEOWNERS ES-1620: Add scans to CODEOWNERS Nov 13, 2023
ronanbrowne
ronanbrowne approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jacob-scott3141 jacob-scott3141 marked this pull request as ready for review November 13, 2023 14:36
@jacob-scott3141 jacob-scott3141 requested review from a team as code owners November 13, 2023 14:36
vkolomeyko
vkolomeyko approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1334/1/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1334/1/ has failed for PR 1334 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1334 build 1

Build Successful:
Jar artifact version produced by this PR: 5.2.0.1-alpha-1699897840005

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1334/1/ has failed for PR 1334 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@jacob-scott3141 jacob-scott3141 merged commit 166e046 into corda:release/os/5.2 Nov 14, 2023
6 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@ronanbrowne ronanbrowne ronanbrowne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacob-scott3141 @ronanbrowne @vkolomeyko