Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-1621: Merging forward updates from release/os/5.1 to release/os/5.2 - 2023-11-13 #1336

Merged
merged 4 commits into from
Nov 13, 2023
Merged

ES-1621: Merging forward updates from release/os/5.1 to release/os/5.2 - 2023-11-13 #1336

merged 4 commits into from
Nov 13, 2023

Conversation

corda-jenkins-ci02[bot]
Copy link
Contributor

This PR was created by the merge bot.

Includes:

@corda-jenkins-ci02 corda-jenkins-ci02 bot requested a review from a team as a code owner November 13, 2023 16:48
@corda-jenkins-ci02
Copy link
Contributor Author

corda-jenkins-ci02 bot commented Nov 13, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1336/3/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@corda-jenkins-ci02
Copy link
Contributor Author

corda-jenkins-ci02 bot commented Nov 13, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1336/3/ has failed for PR 1336 build 3

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

mcgovc
mcgovc approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@mcgovc mcgovc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corda-jenkins-ci02
Copy link
Contributor Author

corda-jenkins-ci02 bot commented Nov 13, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1336/3/ has failed for PR 1336 build 3

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@corda-jenkins-ci02
Copy link
Contributor Author

corda-jenkins-ci02 bot commented Nov 13, 2023 •
edited
Loading

Jenkins build for PR 1336 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.0.1-alpha-1699894591781

ronanbrowne
ronanbrowne approved these changes Nov 13, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ronanbrowne ronanbrowne merged commit ccbd420 into release/os/5.2 Nov 13, 2023
5 of 6 checks passed
@ronanbrowne ronanbrowne deleted the merge-release/os/5.1-release/os/5.2-2023-11-13-1 branch November 13, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcgovc mcgovc mcgovc approved these changes

@ronanbrowne ronanbrowne ronanbrowne approved these changes

Assignees
No one assigned
Labels
merge-bot release/os/5.1 -> release/os/5.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronanbrowne @mcgovc