Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ES-1624: CementApi and update 5.1.0 files to 5.2.0 #1338

Merged
merged 1 commit into from
Nov 14, 2023
Merged

ES-1624: CementApi and update 5.1.0 files to 5.2.0 #1338

merged 1 commit into from
Nov 14, 2023

Conversation

jacob-scott3141
Copy link
Contributor

Run cementApi to update 5.1.0 yaml files to 5.2.0

This will allow them to be picked up in the apiDiff task in the compatibility checks.

@jacob-scott3141 jacob-scott3141 changed the title CementApi and update 5.1.0 files to 5.2.0 ES-1624: CementApi and update 5.1.0 files to 5.2.0 Nov 14, 2023
github-actions[bot]
github-actions bot previously requested changes Nov 14, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

@github-actions github-actions bot dismissed their stale review November 14, 2023 11:14

All good!

@jacob-scott3141 jacob-scott3141 marked this pull request as ready for review November 14, 2023 11:15
@jacob-scott3141 jacob-scott3141 requested a review from a team as a code owner November 14, 2023 11:15
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

ronanbrowne
ronanbrowne approved these changes Nov 14, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1338 build 1

Build Successful:
Jar artifact version produced by this PR: 5.2.0.1-alpha-1699960479412

@jacob-scott3141 jacob-scott3141 merged commit dc99f63 into release/os/5.2 Nov 14, 2023
10 checks passed
@jacob-scott3141 jacob-scott3141 deleted the jacob/ES-1624 branch November 14, 2023 11:51
dickon pushed a commit that referenced this pull request Nov 17, 2023
@jacob-scott3141 @dickon
CementApi and update 5.1.0 files to 5.2.0 (#1338)
48f1f6b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronanbrowne ronanbrowne ronanbrowne approved these changes

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacob-scott3141 @ronanbrowne