Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15805: Avro for getting schema SQL #1389

Merged
merged 5 commits into from
Jan 5, 2024
Merged

CORE-15805: Avro for getting schema SQL #1389

merged 5 commits into from
Jan 5, 2024

Conversation

BenYip123
Copy link
Contributor

@BenYip123 BenYip123 commented Dec 7, 2023 •
edited
Loading

Add avro classes to get the schema SQL for DB creation and migration

corda-runtime-os PR: CORE-15805: REST Endpoint to return SQL for schema creation #5210

@BenYip123 BenYip123 force-pushed the benyip/CORE-15805/rest-endpoint-schema-sql branch from 1c1a24b to 5f7961e Compare December 7, 2023 10:13
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 7, 2023 •
edited
Loading

Jenkins build for PR 1389 build 11

Build Successful:
Jar artifact version produced by this PR: 5.2.0.26-alpha-1704466832203

@BenYip123 BenYip123 force-pushed the benyip/CORE-15805/rest-endpoint-schema-sql branch 2 times, most recently from 411c976 to a7f83ff Compare December 18, 2023 14:06
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 26, 2023
@BenYip123 BenYip123 removed the Stale label Dec 26, 2023
@BenYip123 BenYip123 force-pushed the benyip/CORE-15805/rest-endpoint-schema-sql branch from 45a644f to 58e2f94 Compare January 2, 2024 09:01
@BenYip123 BenYip123 changed the title CORE-15805: Add VirtualNodeSchemaRequest and Response for new endpoint CORE-15805: Avro for getting schema SQL Jan 2, 2024
@BenYip123 BenYip123 mentioned this pull request Jan 2, 2024
Merged
@BenYip123 BenYip123 force-pushed the benyip/CORE-15805/rest-endpoint-schema-sql branch 2 times, most recently from b3cd08e to 2895564 Compare January 4, 2024 16:44
@BenYip123 BenYip123 force-pushed the benyip/CORE-15805/rest-endpoint-schema-sql branch from 2895564 to 05938f2 Compare January 5, 2024 15:00
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@BenYip123 BenYip123 marked this pull request as ready for review January 5, 2024 15:00
@BenYip123 BenYip123 requested a review from a team January 5, 2024 15:00
vkolomeyko
vkolomeyko approved these changes Jan 5, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenYip123 BenYip123 merged commit 0440b8f into release/os/5.2 Jan 5, 2024
@BenYip123 BenYip123 deleted the benyip/CORE-15805/rest-endpoint-schema-sql branch January 5, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BenYip123 @vkolomeyko