Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-18271: add LeveledHash type and method #1390

Closed
wants to merge 1 commit into from
Closed

CORE-18271: add LeveledHash type and method #1390

wants to merge 1 commit into from

Conversation

dickon
Copy link
Contributor

@dickon dickon commented Dec 7, 2023

No description provided.

@lankydan @dickon
NOTICK Storing and loading merkle proofs
7016966 
`MerkleTree.calculateLeveledHashes` creates the level + index of the
hashes to store in the database.
`LoadedMerkleProofTree` takes leveled hashes + indexed merkle leaves to
construct and class that can create a new `MerkleProof`.
@dickon dickon requested a review from a team as a code owner December 7, 2023 13:05
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Dec 7, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1390/1/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1390/1/ has failed for PR 1390 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1390/1/ has failed for PR 1390 build 1

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

@blsemo
Copy link
Contributor

blsemo commented Dec 8, 2023

Do we actually need this on the public API?

@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 18, 2023
@github-actions GitHub Actions
Copy link

This PR was closed because it has been stale for 7 days with no activity.

@github-actions github-actions bot closed this Dec 26, 2023
@github-actions github-actions bot deleted the dickon/CORE-18271-leveled-hashes branch January 22, 2024 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dickon @blsemo @lankydan