CORE-18635 Avro schemas for session encryption operations #1400
Conversation
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
Jenkins build for PR 1400 build 7 Build Successful: |
# Conflicts: # gradle.properties
# Conflicts: # gradle.properties
| "doc": "Error result while performing encryption or decryption operation.", | ||
| "namespace": "net.corda.data.crypto.wire.ops.encryption.response", |
There was a problem hiding this comment.
| "doc": "Error result while performing encryption or decryption operation.", | |
| "namespace": "net.corda.data.crypto.wire.ops.encryption.response", | |
| "namespace": "net.corda.data.crypto.wire.ops.encryption.response", | |
| "doc": "Error result while performing encryption or decryption operation.", |
| "doc": "The symmetric key alias.", | ||
| "type": ["null", "string"] |
There was a problem hiding this comment.
| "doc": "The symmetric key alias.", | |
| "type": ["null", "string"] | |
| "type": ["null", "string"] | |
| "doc": "The symmetric key alias.", |
| "doc": "The symmetric key alias.", | ||
| "type": ["null", "string"] |
There was a problem hiding this comment.
| "doc": "The symmetric key alias.", | |
| "type": ["null", "string"] | |
| "type": ["null", "string"] | |
| "doc": "The symmetric key alias.", |
| "doc": "The data to decrypt." | ||
| }, | ||
| { | ||
| "name": "context", |
There was a problem hiding this comment.
I think adding this context was was decided at design level.
However, I have seen before a case where we have been using it while we shouldn't and we had to go in there and revert all of that, to use some other field instead back then (IRRC we used to pass the signature spec in context. This piece of work can be found here).
I would say if you are not planning on using it remove it as it will cause at the very least confusion on the API, like what is good for. It can always be added later if found it's needed which I doubt It will be needed.
There was a problem hiding this comment.
I prefer to remove it.
@dickon WDYT?
| "doc": "Request to decrypt the given byte array", | ||
| "fields": [ | ||
| { | ||
| "name": "category", |
There was a problem hiding this comment.
nit: so this means we could be passing in any category. So for example LEDGER (ledger keys are meant to be used for signing) to decrypt secrets. Should we be restricting this field with an enum of valid categories?
|
APIs for an implementation of encryption and decryption.
Runtime pull request in corda/corda-runtime-os#5258