Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-1747: remove unnecessary Gradle plugin reference #1412

Merged
merged 3 commits into from
Dec 18, 2023

Conversation

ronanbrowne
Copy link
Contributor

@ronanbrowne ronanbrowne commented Dec 15, 2023

Remove direct reference to the Artifactory plugin, this is dead code and not required - The plugin is dynamically applied via the internal publishing plugin we maintain - we are declaring it in the project a second time for no reason.

As such, the references in the toml file and gradle.properties are also being removed.

I have verified publishing is unaffected by this, as can be observed in the logs of the PR gate shown below:

00:16:39.378  :artifactoryDeploy (Thread[included builds Thread 2,5,main]) started.
00:16:39.379  [pool-17-thread-3] Deploying artifact: https://software.r3.com/artifactory/corda-os-maven-unstable/net/corda/corda-api/5.2.0.17-alpha-1702663869186/corda-api-5.2.0.17-alpha-1702663869186.module
00:16:39.379  [pool-17-thread-2] Deploying artifact: https://software.r3.com/artifactory/corda-os-maven-unstable/net/corda/corda-base/5.2.0.17-alpha-1702663869186/corda-base-5.2.0.17-alpha-1702663869186-javadoc.jar
00:16:39.379  [pool-17-thread-1] Deploying artifact: https://software.r3.com/artifactory/corda-os-maven-unstable/net/corda/corda-application/5.2.0.17-alpha-1702663869186/corda-application-5.2.0.17-alpha-1702663869186-javadoc.jar
00:16:39.637  [pool-17-thread-3] Deploying artifact: https://software.r3.com/artifactory/corda-os-maven-unstable/net/corda/corda-api/5.2.0.17-alpha-1702663869186/corda-api-5.2.0.17-alpha-1702663869186.pom
and so on ....

@ronanbrowne ronanbrowne changed the title ES-1747: remove unnecessary pluign refrence ES-1747: remove unnecessary Gradle plugin refrence Dec 15, 2023
@ronanbrowne ronanbrowne changed the title ES-1747: remove unnecessary Gradle plugin refrence ES-1747: remove unnecessary Gradle plugin reference Dec 15, 2023
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 15, 2023

Jenkins build for PR 1412 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.0.17-alpha-1702895630912

@ronanbrowne ronanbrowne marked this pull request as ready for review December 15, 2023 18:28
@ronanbrowne ronanbrowne requested review from a team as code owners December 15, 2023 18:28
Copy link

@driessamyn driessamyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ronanbrowne ronanbrowne merged commit dfe053d into release/os/5.2 Dec 18, 2023
@ronanbrowne ronanbrowne deleted the ronanb/ES-1747/remove-dead-code branch December 18, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants