ES-1755: Allow use of TOML file in settings.gradle to leverage version catalog and thus dependabot updates #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ronanbrowne
changed the title
|
Scanning for breaking API changes introduced by this PR Scan Succeeded |
|
Jenkins build for PR 1416 build 2 Build Successful: |
ronanbrowne
changed the title
ronanbrowne
deleted the
ronanb/ES-1755/workaround-version-catalog-limitations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change provides a workaround for some limitations of the Gradle version catalog, namely that it is not natively readable from
settings.gradledue to the order of resolution by Gradle's builds life cycle when evaluating settings.gradle and the TOML file in the gradle directory.To get around this, We manually parse the
TOMLfile, using standard Groovy means, to return the version in question, using a Regex pattern to parse the file, then return the version e.g. for an entry in the TOML file likegradleEnterpriseVersion = "3.14.1"just3.14.1would be returned and then passed as the plugin parameter.This allows us to continue to leverage the version catalogue for items which must be declared in settings.gradle.
Further reading is available here on Gradles forums, where a solution similar to this is suggested by one of their engineers regarding using the Gradle Enterprise plugins with a version catalog.