Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-16870 Support nullable parameters in queries #1417

Merged
merged 7 commits into from
Dec 21, 2023
Merged

CORE-16870 Support nullable parameters in queries #1417

merged 7 commits into from
Dec 21, 2023

Conversation

nkovacsx
Copy link
Contributor

Overview

Right now nullable parameters are not supported in named queries, after this change we'll support setting null parameters. This feature was requested by various teams before.

@nkovacsx
CORE-16870 Support nullable parameters in queries
1101034
@nkovacsx
vbump
269cc99
@nkovacsx
Merge branch 'release/os/5.2' of https://github.com/corda/corda-api i…
c883bce 
…nto nandor/CORE-16870/nullable-params-queries

# Conflicts:
#	gradle.properties
@nkovacsx
Merge branch 'release/os/5.2' of https://github.com/corda/corda-api i…
0e50c09 
…nto nandor/CORE-16870/nullable-params-queries

# Conflicts:
#	gradle.properties
@nkovacsx
vbump
2dc25d2
@nkovacsx nkovacsx requested a review from a team as a code owner December 19, 2023 09:42
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023 •
edited
Loading

Scanning for breaking API changes introduced by this PR

Scan Failed: https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1417/2/

If the breaking changes are intentional, run ./gradlew cementApi and get approval from the Corda team leads.

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023 •
edited
Loading

Jenkins build for PR 1417 build 2

Build Successful:
Jar artifact version produced by this PR: 5.2.0.22-alpha-1703157377737

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-non-functional-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1417/2/ has failed for PR 1417 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-non-functional-test

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 19, 2023 •
edited
Loading

Non-blocking downstream job failed for corda-e2e-test

https://ci02.dev.r3.com/job/Corda5/job/corda-api-compatibility/job/PR-1417/2/ has failed for PR 1417 build 2

Please investigate if your changes may have broken compilation on https://github.com/corda/corda-e2e-tests

blsemo
blsemo previously approved these changes Dec 19, 2023
View reviewed changes
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nkovacsx nkovacsx changed the title CORE-16780 Support nullable parameters in queries CORE-16870 Support nullable parameters in queries Dec 19, 2023
@nkovacsx
Merge branch 'release/os/5.2' of https://github.com/corda/corda-api i…
8f49096 
…nto nandor/CORE-16870/nullable-params-queries

# Conflicts:
#	gradle.properties
@nkovacsx
vbump
82913c7
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 21, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@nkovacsx nkovacsx merged commit c6d34bb into release/os/5.2 Dec 21, 2023
6 of 7 checks passed
@nkovacsx nkovacsx deleted the nandor/CORE-16870/nullable-params-queries branch December 21, 2023 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-johnson-r3 simon-johnson-r3 simon-johnson-r3 approved these changes

@blsemo blsemo blsemo left review comments

@driessamyn driessamyn Awaiting requested review from driessamyn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nkovacsx @blsemo @simon-johnson-r3