-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-18533: Remove Checkpoint Retry #1429
Conversation
Jenkins build for PR 1429 build 10 Build Successful: |
Scanning for breaking API changes introduced by this PR Scan Succeeded |
fa19497
to
059fc21
Compare
36a5c73
to
d09b2dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -33,7 +33,7 @@ | |||
"default": 16000 | |||
}, | |||
"maxFlowSleepDuration": { | |||
"description": "The maximum delay in milliseconds before Corda schedules a periodic wake-up.", | |||
"description": "Deprecated. The maximum delay in milliseconds before Corda schedules a periodic wake-up.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this the official way we are to deprecate configs? Just curious as i know some other ones which need deprecating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure to be honest... @simon-johnson-r3, thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
evolution, unmatched values do not throw an error but are resolved
to the default instead).
"PipelineState" avro schema.
types one minor version at a time).
Runtime Change: corda/corda-runtime-os#5374