Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18533: Remove Checkpoint Retry #1429

Merged
merged 5 commits into from
Jan 5, 2024

Conversation

jujoramos
Copy link
Contributor

@jujoramos jujoramos commented Jan 2, 2024

  • Remove "RetryState" avro schema.
  • Move "FlowStates" enumeration to its own avro schema definition file.
  • Remove "RETRYING" and set "FAILED" as the default value (for schema
    evolution, unmatched values do not throw an error but are resolved
    to the default instead).
  • Remove "retryState" and "maxFlowSleepDuration" fields from the
    "PipelineState" avro schema.
  • Remove "CheckpointSchemaCompatibilityTest" (we only support evolving
    types one minor version at a time).
  • Add schema compatibility tests for "FlowStates" and "PipelineState".

Runtime Change: corda/corda-runtime-os#5374

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jan 2, 2024

Jenkins build for PR 1429 build 10

Build Successful:
Jar artifact version produced by this PR: 5.2.0.26-alpha-1704461960378

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@jujoramos jujoramos changed the title CORE-18533: Remove Checkpoint Retry Logic CORE-18533: Remove Checkpoint Retry Jan 4, 2024
Copy link
Contributor

@simon-johnson-r3 simon-johnson-r3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jujoramos jujoramos marked this pull request as ready for review January 5, 2024 12:04
@jujoramos jujoramos requested a review from a team as a code owner January 5, 2024 12:04
@@ -33,7 +33,7 @@
"default": 16000
},
"maxFlowSleepDuration": {
"description": "The maximum delay in milliseconds before Corda schedules a periodic wake-up.",
"description": "Deprecated. The maximum delay in milliseconds before Corda schedules a periodic wake-up.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the official way we are to deprecate configs? Just curious as i know some other ones which need deprecating.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure to be honest... @simon-johnson-r3, thoughts?

Copy link
Contributor

@LWogan LWogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jan 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@jujoramos jujoramos merged commit c23d34c into corda:release/os/5.2 Jan 5, 2024
@jujoramos jujoramos deleted the feature/CORE-18533 branch January 5, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants