Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18532: Explicit Crypto Retry Settings #1430

Merged
merged 3 commits into from
Jan 4, 2024

Conversation

jujoramos
Copy link
Contributor

Instead of setting the maximum amount of retries within the code and
ignore the values configured by the user, set the minimum and maximum
allowed values in the configuration schema directly.

Instead of setting the maximum amount of retries within the code and
ignore the values configured by the user, set the minimum and maximum
allowed values in the configuration schema directly.
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jan 2, 2024

Jenkins build for PR 1430 build 3

Build Successful:
Jar artifact version produced by this PR: 5.2.0.24-alpha-1704273882308

Copy link

sonarqubecloud bot commented Jan 3, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@dickon dickon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Documents what we already enforce rather than silently ignoring extra retries.

@jujoramos jujoramos merged commit 6d370ad into corda:release/os/5.2 Jan 4, 2024
5 checks passed
@jujoramos jujoramos deleted the feature/CORE-18532 branch January 4, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants