Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-15310: Update slf4j to v2 #1645

Merged
merged 4 commits into from
Jun 12, 2024
Merged

CORE-15310: Update slf4j to v2 #1645

merged 4 commits into from
Jun 12, 2024

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented May 15, 2024 •
edited by vkolomeyko
Loading

@josephzunigadaly josephzunigadaly self-assigned this May 15, 2024
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented May 15, 2024 •
edited
Loading

Jenkins build for PR 1645 build 7

Build Successful:
Jar artifact version produced by this PR: 5.3.0.14-alpha-1718034718682

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15310-slf4j-2 branch from daab7e7 to aaeaed2 Compare May 22, 2024 08:12
@github-actions GitHub Actions
Copy link

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label May 30, 2024
@josephzunigadaly josephzunigadaly force-pushed the jzd/CORE-15310-slf4j-2 branch from aaeaed2 to 2501644 Compare May 30, 2024 08:26
@github-actions github-actions bot removed the Stale label May 31, 2024
@filipesoliveira filipesoliveira mentioned this pull request Jun 5, 2024
Merged
@filipesoliveira filipesoliveira force-pushed the jzd/CORE-15310-slf4j-2 branch from 46bffa8 to fb12ee9 Compare June 6, 2024 09:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@vkolomeyko vkolomeyko marked this pull request as ready for review June 11, 2024 11:09
@vkolomeyko vkolomeyko requested review from a team as code owners June 11, 2024 11:09
@vkolomeyko vkolomeyko self-requested a review June 11, 2024 11:09
vkolomeyko
vkolomeyko approved these changes Jun 11, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@filipesoliveira
Copy link
Contributor

filipesoliveira commented Jun 12, 2024 •
edited
Loading

Hi @driessamyn,

Are you happy with the current state of the PR?

Runtime-os, e2e and QA tests are green.

References:
QA tests - https://ci05.dev.r3.com/blue/organizations/jenkins/QA%2FCRAFT5%2FCraft_Tests%2FC5%2FLatest%2FOpensource%2FEKS%2FOS-qa-regpack-tests-flow-eks/detail/main/23/pipeline/
e2e tests - https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-rebuild-e2e-tests/detail/PR-6150/13/pipeline
runtime-os - corda/corda-runtime-os#6150

@vkolomeyko vkolomeyko merged commit 8bc684d into release/os/5.3 Jun 12, 2024
7 checks passed
@vkolomeyko vkolomeyko deleted the jzd/CORE-15310-slf4j-2 branch June 12, 2024 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@driessamyn driessamyn driessamyn left review comments

@owenstanford owenstanford owenstanford approved these changes

Assignees

@filipesoliveira filipesoliveira

@vkolomeyko vkolomeyko

@josephzunigadaly josephzunigadaly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@josephzunigadaly @filipesoliveira @driessamyn @vkolomeyko @owenstanford