-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CORE-20522: Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-06-27 #1665
CORE-20522: Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-06-27 #1665
Conversation
Introduces database and Avro schemas to enable persistence and reconciliation of locally-hosted identities.
…lugin (#1641) * ES-2351: generate new API yaml
Please remember to 'Merge' all forward merges and do not 'Squash and Merge' |
Scanning for breaking API changes introduced by this PR Scan Succeeded |
Jenkins build for PR 1665 build 3 Build Successful: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (regarding my changes not brought forward and jenkins change)
|
||
class HostedIdentityEntryCompatibilityTest { | ||
@Test | ||
fun `check HostedIdentityEntry schema changes between Corda 5_2 and 5_2_1 are compatible`() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to modify this test to check 5.3 instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't look like it based on similar tests, for example - flow status, decline registration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
This PR was created by the merge bot.
Includes: