Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-20522: Merging forward updates from release/os/5.2 to release/os/5.3 - 2024-06-27 #1665

Merged

Conversation

corda-jenkins-ci02[bot]
Copy link
Contributor

@corda-jenkins-ci02 corda-jenkins-ci02 bot commented Jun 27, 2024

This PR was created by the merge bot.

Includes:

YashNabar and others added 3 commits May 9, 2024 12:01
Introduces database and Avro schemas to enable persistence and reconciliation of locally-hosted identities.
@corda-jenkins-ci02
Copy link
Contributor Author

Please remember to 'Merge' all forward merges and do not 'Squash and Merge'

seanbrereton
seanbrereton previously approved these changes Jun 27, 2024
@corda-jenkins-ci02
Copy link
Contributor Author

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor Author

corda-jenkins-ci02 bot commented Jun 28, 2024

Jenkins build for PR 1665 build 3

Build Successful:
Jar artifact version produced by this PR: 5.3.0.15-alpha-1719841195391

Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (regarding my changes not brought forward and jenkins change)


class HostedIdentityEntryCompatibilityTest {
@Test
fun `check HostedIdentityEntry schema changes between Corda 5_2 and 5_2_1 are compatible`() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to modify this test to check 5.3 instead?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look like it based on similar tests, for example - flow status, decline registration.

@YashNabar YashNabar marked this pull request as ready for review July 1, 2024 13:01
@YashNabar YashNabar requested review from a team as code owners July 1, 2024 13:01
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@nikinagy nikinagy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarqubecloud bot commented Jul 1, 2024

@YashNabar YashNabar merged commit 90e35e8 into release/os/5.3 Jul 2, 2024
4 checks passed
@YashNabar YashNabar deleted the merge-release/os/5.2-release/os/5.3-2024-06-27-152 branch July 2, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants