Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-20543: Update ChangeUserParentGroupIdRequest to use loginName #1677

Merged
merged 2 commits into from
Jul 25, 2024
Merged

CORE-20543: Update ChangeUserParentGroupIdRequest to use loginName #1677

merged 2 commits into from
Jul 25, 2024

Conversation

BenYip123
Copy link
Contributor

  • Updated the ChangeUserParentGroupIdRequest to be loginName instead of userId, as all user operations take loginName as input.

@BenYip123 BenYip123 requested a review from a team July 24, 2024 15:46
@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Jul 24, 2024 •
edited
Loading

Jenkins build for PR 1677 build 2

Build Successful:
Jar artifact version produced by this PR: 5.3.0.16-alpha-1721838135404

@BenYip123 BenYip123 requested a review from a team as a code owner July 24, 2024 16:21
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

vkolomeyko
vkolomeyko approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BenYip123 BenYip123 merged commit 513cf2a into release/os/5.3 Jul 25, 2024
4 checks passed
@BenYip123 BenYip123 deleted the benyip/CORE-20737/update-ChangeUserParentGroupIdRequest branch July 25, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkolomeyko vkolomeyko vkolomeyko approved these changes

@Tom-Fitzpatrick Tom-Fitzpatrick Tom-Fitzpatrick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BenYip123 @Tom-Fitzpatrick @vkolomeyko