Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

R3SOL-368 Downgrade jackson to 2.17.2 #1700

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

williamvigorr3
Copy link
Contributor

@williamvigorr3 williamvigorr3 commented Oct 10, 2024

Upgrading Jackson from 2.17.2 to 2.18.0 (see fb818fe) in Corda API has broken some of the Ledger Tests.

Causing the tests to fail with:

com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Cannot construct instance of `net.corda.v5.ledger.common.transaction.CordaPackageSummary` (no Creators, like default constructor, exist): abstract types either need to be mapped to concrete types, have custom deserializer, or contain additional type information
 at [Source: REDACTED (`StreamReadFeature.INCLUDE_SOURCE_IN_LOCATION` disabled); line: 1, column: 604] (through reference chain: net.corda.ledger.common.data.transaction.TransactionMetadataImpl["cpkMetadata"]->java.util.ArrayList[0])

It looks like Jackson is trying to construct CordaPackageSummary (which is an interface) when deserialising instead of CordaPackageSummaryImpl.

Copy link

sonarcloud bot commented Oct 10, 2024

@corda-jenkins-ci02
Copy link
Contributor

Scanning for breaking API changes introduced by this PR

Scan Succeeded

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 1700 build 2

Build Successful:
Jar artifact version produced by this PR: 5.3.0.16-alpha-1728575408497

@williamvigorr3 williamvigorr3 marked this pull request as ready for review October 15, 2024 07:47
@williamvigorr3 williamvigorr3 requested a review from a team as a code owner October 15, 2024 07:47
@williamvigorr3 williamvigorr3 merged commit 607927b into release/os/5.3 Oct 15, 2024
6 checks passed
@williamvigorr3 williamvigorr3 deleted the WillV/R3SOL-368-Fix-Jackson branch October 15, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants