Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-16786: Update pf4j to 3.10 #192

Merged
merged 1 commit into from
Sep 13, 2023
Merged

CORE-16786: Update pf4j to 3.10 #192

merged 1 commit into from
Sep 13, 2023

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented Sep 12, 2023 •
edited
Loading

@josephzunigadaly josephzunigadaly self-assigned this Sep 12, 2023
@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 192 build 1

Build Successful:
Jar artifact version produced by this PR: 5.1.0-alpha-1694533046945

@josephzunigadaly josephzunigadaly marked this pull request as ready for review September 13, 2023 08:53
@josephzunigadaly josephzunigadaly requested a review from a team as a code owner September 13, 2023 08:53
ronanbrowne
ronanbrowne approved these changes Sep 13, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephzunigadaly josephzunigadaly requested a review from a team September 13, 2023 13:30
@josephzunigadaly josephzunigadaly merged commit bdf7c8a into release/5.1 Sep 13, 2023
@josephzunigadaly josephzunigadaly deleted the jzd/CORE-16786-Update-pf4j-to-3.10 branch September 13, 2023 13:48
josephzunigadaly added a commit that referenced this pull request Sep 13, 2023
@josephzunigadaly
Revert "CORE-16786: Update pf4j to 3.10 (#192)"
304f82c 
This reverts commit bdf7c8a.
josephzunigadaly added a commit that referenced this pull request Sep 14, 2023
@josephzunigadaly
Revert "CORE-16786: Update pf4j to 3.10 (#192)" (#193)
2f6a4a9 
This reverts commit bdf7c8a.

3.10 pulls in slf4j 2.0, need to consider the effect of this change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronanbrowne ronanbrowne ronanbrowne approved these changes

@Tom-Fitzpatrick Tom-Fitzpatrick Tom-Fitzpatrick approved these changes

@BenYip123 BenYip123 BenYip123 approved these changes

Assignees

@josephzunigadaly josephzunigadaly

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@josephzunigadaly @ronanbrowne @Tom-Fitzpatrick @BenYip123