Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-16786: Upgrade CLI PF4J to 3.10 and SLF4J to 2.0.6 #194

Merged

Conversation

josephzunigadaly
Copy link
Contributor

@josephzunigadaly josephzunigadaly commented Sep 27, 2023

This change upgrades PF4J to 3.10, the change log can be viewed here:
https://github.com/pf4j/pf4j/blob/master/CHANGELOG.md#3100---2023-09-06

One of the changes included in PF4J is an upgrade to SLF4J 2. This change uses SLF4J 2 for the CLI.

@josephzunigadaly josephzunigadaly self-assigned this Sep 27, 2023
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Sep 27, 2023

Jenkins build for PR 194 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0-alpha-1695915864838

Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@josephzunigadaly josephzunigadaly changed the title CORE-15310: Upgrade CLI PF4J to 3.10 and SLF4J to 2.0.6 CORE-16786: Upgrade CLI PF4J to 3.10 and SLF4J to 2.0.6 Sep 29, 2023
josephzunigadaly added a commit to corda/corda-runtime-os that referenced this pull request Sep 29, 2023
This change upgrades PF4J to 3.10, the change log can be viewed here:
https://github.com/pf4j/pf4j/blob/master/CHANGELOG.md#3100---2023-09-06

One of the changes included in PF4J is an upgrade to SLF4J 2. This change uses SLF4J 2 for the CLI and SLF4J 1 for Corda itself.

Related CLI PR: corda/corda-cli-plugin-host#194
@josephzunigadaly josephzunigadaly merged commit ca1c730 into release/5.1 Sep 29, 2023
2 checks passed
@josephzunigadaly josephzunigadaly deleted the jzd/CORE-15310-Upgrade-SLF4J-from-1.7-to-2.x branch September 29, 2023 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants