Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-2248: Adding 'merge-release' to stale-branch-remove exemption regex #228

Conversation

LukeBrowne-R3
Copy link
Contributor

Problem Description
When a remove-stale github action is triggered, it causes an error on merge branches as there is no associated author.

Solution
Adding 'merge-release' to the exemptions regex to prevent remove-stale from flagging a merge branch for removal.

https://github.com/corda/corda-e2e-tests/actions/runs/8750709270/job/24014775525
branch merge-release/5.2-release/5.3-2024-02-28-14 -> branch was last updated by (unknown user) on 2024-02-28T14:10:05Z branch merge-release/5.2-release/5.3-2024-02-28-14 is exempted

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR title failed to match regex -> ^((CORDA|EG|ENT|INFRA|CORE|DOC|ES)-\d+)(.*)

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@LukeBrowne-R3 LukeBrowne-R3 changed the title Es 2248 adding 'merge release' to stale branch remove exemption regex ES-2248: Adding 'merge-release' to stale-branch-remove exemption regex Apr 22, 2024
@github-actions github-actions bot dismissed their stale review April 22, 2024 11:22

All good!

@corda-jenkins-ci02
Copy link
Contributor

Jenkins build for PR 228 build 1

Build Successful:
Jar artifact version produced by this PR: 5.3.0-alpha-1713784930795

@LukeBrowne-R3
Copy link
Contributor Author

Issues with merging changes and rebasing. Going to make the change when viewing 5.2

@github-actions github-actions bot deleted the ES-2248-Adding-'merge-release'-to-stale-branch-remove-exemption-regex branch June 6, 2024 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants