Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ES-1978: corrected syntax in CODEOWNERS file #236

Conversation

wzur-r3
Copy link
Contributor

@wzur-r3 wzur-r3 commented Apr 30, 2024

* `.ci/*` only catches files directly in `.ci` folder, any subfolders
are not affected
* `/.ci/` correctly sets ownership of all files in that folder to
Infrastructure and Release team
* same for `.gradle` folder
@wzur-r3 wzur-r3 requested a review from a team as a code owner April 30, 2024 15:49
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Apr 30, 2024

Jenkins build for PR 236 build 3

Build Successful:
Jar artifact version produced by this PR: 5.3.0-alpha-1714492437521

vkolomeyko
vkolomeyko previously approved these changes Apr 30, 2024
Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 30, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@vkolomeyko vkolomeyko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wzur-r3 wzur-r3 merged commit 55acd0f into release/5.3 Apr 30, 2024
2 checks passed
@wzur-r3 wzur-r3 deleted the wzur-r3/ES-1978/Create-5-3-release-branches-fixed-codeowners branch April 30, 2024 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants