Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-1134: Replace cordformation DSL Closure elements with Action. #405

Merged
merged 2 commits into from
Apr 6, 2021
Merged

CORE-1134: Replace cordformation DSL Closure elements with Action. #405

merged 2 commits into from
Apr 6, 2021

Conversation

chrisr3
Copy link
Contributor

@chrisr3 chrisr3 commented Apr 3, 2021 •
edited
Loading

Replace Closure in cordformation's DSL with modern Action. This makes cordformation compatible with Gradle's Kotlin DSL as well as with Groovy.

This should fix #403.

@chrisr3 chrisr3 added the bug Something isn't working label Apr 3, 2021
@chrisr3 chrisr3 self-assigned this Apr 3, 2021
@chrisr3 chrisr3 force-pushed the chrisr3-cordformation-action branch 6 times, most recently from 0af1b2d to d389e12 Compare April 3, 2021 23:34
@chrisr3 chrisr3 force-pushed the chrisr3-cordformation-action branch from be5bb87 to 514d047 Compare April 4, 2021 19:23
@chrisr3 chrisr3 requested a review from palade April 5, 2021 23:21
palade
palade approved these changes Apr 6, 2021
View reviewed changes
Copy link
Contributor

@palade palade left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposed changes look good to me!

@chrisr3 chrisr3 merged commit c8e7228 into release/5.0 Apr 6, 2021
@chrisr3 chrisr3 deleted the chrisr3-cordformation-action branch April 6, 2021 08:33
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
068b551 
)

* Replace cordformation DSL Closure elements with Action.
* Remove unused imports.
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
fd49533 
)

* Replace cordformation DSL Closure elements with Action.
* Remove unused imports.
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
d35e210 
)

* Replace cordformation DSL Closure elements with Action.
* Remove unused imports.
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
f30808e 
)

* Replace cordformation DSL Closure elements with Action.
* Remove unused imports.
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
35c9cb0 
)

* Replace cordformation DSL Closure elements with Action.
* Remove unused imports.
@chrisr3 chrisr3 mentioned this pull request Apr 6, 2021
Merged
chrisr3 added a commit that referenced this pull request Apr 6, 2021
@chrisr3
CORE-1134: Replace cordformation DSL Closure elements with Action. (#405
edff1e8 
) (#406)

* Replace cordformation DSL Closure elements with Action. (#405)
* Remove unused imports.
* Update tests not to use deprecated DSL for CorDapps.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palade palade palade approved these changes

Assignees

@chrisr3 chrisr3

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chrisr3 @palade