Skip to content

Commit

Permalink
CORE-17768 Fixed unit test
Browse files Browse the repository at this point in the history
  • Loading branch information
mbrkic-r3 committed Oct 24, 2023
1 parent 2d7c0e7 commit bafeed3
Showing 1 changed file with 3 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,8 @@ class MessageBusConfigResolverTest {
mapOf(
BOOTSTRAP_SERVERS_PROP to "kafka:1001",
SSL_KEYSTORE_PROP to "foo/bar",
CLIENT_ID_PROP to "eventConsumer--$CLIENT_ID"
CLIENT_ID_PROP to "eventConsumer--$CLIENT_ID",
GROUP_ID_PROP to "group-cooperative"
)
),
ConsumerRoles.EVENT_LOG to getExpectedConsumerProperties(
Expand Down Expand Up @@ -296,7 +297,7 @@ class MessageBusConfigResolverTest {
// configuration block doesn't ensure that only shared properties are placed in there. This doesn't matter from
// Kafka's perspective, so we just assert on the properties that do matter here.
private fun assertConsumerProperties(expected: Properties, actual: Properties) {
// TODO assertEquals(expected[GROUP_ID_PROP], actual[GROUP_ID_PROP])
assertEquals(expected[GROUP_ID_PROP], actual[GROUP_ID_PROP])
assertEquals(expected[CLIENT_ID_PROP], actual[CLIENT_ID_PROP])
assertEquals(expected[ISOLATION_LEVEL_PROP], actual[ISOLATION_LEVEL_PROP]) // Verify an enforced property
assertEquals(expected[BOOTSTRAP_SERVERS_PROP], actual[BOOTSTRAP_SERVERS_PROP]) // Verify overriding a default
Expand Down

0 comments on commit bafeed3

Please sign in to comment.