CORE-16983 / CORE-16967 Atomic Swap with Facade #4691
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a including all nested types used inside DigitalSignatureAndMetadata and especially proof of batch signature. The test using extended UtxoLedgerTest class which produces transaction with a Merkle tree proof - signed by "signBatch". Due to quite awkward dependencies between modules, the test is in UTXO module - as only this module can produce a sample signature with proof.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
vlajos
reviewed
Sep 22, 2023
| @@ -48,6 +48,7 @@ dependencies { | |||
| implementation project(':libs:platform-info') | |||
| implementation project(":libs:serialization:serialization-avro") | |||
| implementation project(":libs:tracing") | |||
| implementation project(':libs:crypto:merkle-impl') | |||
There was a problem hiding this comment.
Depending on -impl looks a bit suspicious.
Dependencies should be injected via OSGi.
Although probably some direct constructors are not available via OSGi.
…com.fasterxml.jackson.databind.MappingIterator cannot be cast to class java.lang.String 2. Move addition of new Jackson deserializers to initialisation of JsonMarshallingServiceImpl, instead adding them in a pretty much random method "setDeserializer" which may be not invoked
…a request/response does.
…licit inner assignment of new ProofOfAction serialization module, as it will be "injected" from the "main" serializer. Remove unnecessary introduced code differences to the syntax branch.
…rop/jmac/CORE-16983 # Conflicts: # components/flow/flow-service/build.gradle # components/flow/flow-service/src/main/kotlin/net/corda/flow/application/services/impl/FacadeServiceImpl.kt # components/flow/flow-service/src/test/kotlin/net/corda/flow/application/services/interop/dispatchers/FacadeServerDispatcherSpec.kt # components/flow/flow-service/src/test/kotlin/net/corda/flow/application/services/interop/proxies/FacadeClientProxySpec.kt # components/flow/flow-service/src/test/kotlin/net/corda/flow/application/services/interop/roundtrip/RoundTripTest.kt # gradle.properties # testing/cpbs/interop-token-demo-workflows/src/main/kotlin/com/r3/corda/demo/interop/tokens/workflows/interop/SwapResponderSubFlow.kt
|
Jenkins build for PR 4691 build 26 Build Successful: |
szymonsztuka
changed the title
# Conflicts: # components/ledger/ledger-utxo-flow/src/test/kotlin/net/corda/ledger/utxo/flow/impl/transaction/signatureproof/SignatureProofTests.kt # testing/ledger/ledger-utxo-base-test/src/main/kotlin/net/corda/ledger/utxo/test/UtxoLedgerWithBatchSignerTest.kt
szymonsztuka
changed the title
|
This PR is stale because it has been open 7 days with no activity. Remove the |
|
This PR was closed because it has been stale for 7 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
API additions in corda/corda-api#1282