CORE-12411 - Add declination reason

[dimosr]

Changes

This change adjusts the MGM code, so that it communicates the reason for declined requests back to the user and the appropriate handler, so that this information is stored in the DB and surfaced to the user. In some cases, we don't want to reveal potentially sensitive information to a member (especially in cases where the request hasn't gone fully through authentication yet). In these cases, a general message is communicated instructing the user to communicate with the network operator for more details.

Depends on: corda/corda-api#1261

Note: api version will be switched back to beta+ before merging. It's switched to alpha temporarily to test the integration.

Testing

Tested manually one of these cases to ensure everything works end-to-end, by adjusting one of our e2e tests to register a notary with a vnode name that is the same as the notary service name.

Registration request (as viewed from the user side) - Before:

{
  "registrationId": "a0c5e535-d121-4554-b211-53891041c0a1",
  "registrationSent": "2023-09-25T08:41:03.873Z",
  "registrationUpdated": "2023-09-25T08:41:04.488Z",
  "registrationStatus": "DECLINED",
  "memberInfoSubmitted": {
    "data": {
      "registrationProtocolVersion": "1",
      "corda.session.keys.0.id": "958863771798",
      "corda.session.keys.0.signature.spec": "SHA256withECDSA",
      "corda.ledger.keys.0.id": "AE42C9D61F05",
      "corda.ledger.keys.0.signature.spec": "SHA256withECDSA",
      "corda.endpoints.0.connectionURL": "https://corda-p2p-gateway-worker.dimosraptis-cluster-b:8080",
      "corda.endpoints.0.protocolVersion": "1",
      "corda.roles.0": "notary",
      "corda.notary.service.name": "O=NotaryService, L=London, C=GB",
      "corda.notary.service.flow.protocol.name": "com.r3.corda.notary.plugin.nonvalidating",
      "corda.notary.service.flow.protocol.version.0": "1",
      "corda.notary.keys.0.id": "1309B3FAF53C",
      "corda.notary.keys.0.signature.spec": "SHA256withECDSA"
    }
  },
  "reason": null,
  "serial": 0
}

Registration request (as viewed from the user side) - After:

{
  "registrationId": "794ec5f2-f9dc-4fd2-9da0-53b4397c5fcf",
  "registrationSent": "2023-09-25T14:41:59.909Z",
  "registrationUpdated": "2023-09-25T14:42:15.219Z",
  "registrationStatus": "DECLINED",
  "memberInfoSubmitted": {
    "data": {
      "registrationProtocolVersion": "1",
      "corda.session.keys.0.id": "D9CF07C5CD29",
      "corda.session.keys.0.signature.spec": "SHA256withECDSA",
      "corda.ledger.keys.0.id": "5FE47FE47C07",
      "corda.ledger.keys.0.signature.spec": "SHA256withECDSA",
      "corda.endpoints.0.connectionURL": "https://localhost:8080",
      "corda.endpoints.0.protocolVersion": "1",
      "corda.roles.0": "notary",
      "corda.notary.service.name": "O=NotaryService, L=London, C=GB",
      "corda.notary.service.flow.protocol.name": "com.r3.corda.notary.plugin.nonvalidating",
      "corda.notary.service.flow.protocol.version.0": "1",
      "corda.notary.keys.0.id": "14BA31F11AEF",
      "corda.notary.keys.0.signature.spec": "SHA256withECDSA"
    }
  },
  "reason": "The virtual node `O=NotaryService, L=London, C=GB` and the notary service `O=NotaryService, L=London, C=GB` name cannot be the same.",
  "serial": 0
}

I also run the following tests:

• e2e tests: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda5-e2e-tests/detail/release%2F5.1/902/pipeline/ (only UtxoLedgerTests which have been temporarily broken on the release branch)
• multi-cluster e2e tests: https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-e2e-tests-multi-cluster-tests/detail/release%2F5.1/138/pipeline/
• cross-version compatibility tests (given some schemas that are sent across clusters have been changed): https://ci02.dev.r3.com/blue/organizations/jenkins/Corda5%2Fcorda-e2e-tests-cross-compatibility-tests/detail/release%2F5.1/49/pipeline

[corda-jenkins-ci02]

Jenkins build for PR 4696 build 8

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1695741367784
Helm chart version produced by this PR: 5.1.0-alpha.1695741367784
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-4696/corda

[yift-r3]

LGTM (but we need to merge the API change first).

[yift-r3]

LGTM