Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CORE-17623 - move-token-selection-processor #4835

Merged
merged 15 commits into from
Oct 12, 2023
Merged

CORE-17623 - move-token-selection-processor #4835

merged 15 commits into from
Oct 12, 2023

Conversation

driessamyn
Copy link
Contributor

@driessamyn driessamyn commented Oct 11, 2023 •
edited
Loading

Move the Token Selection Processor in the stand-alone worker.

corda/corda-api#1291 is a pre-requisite for this.

@driessamyn driessamyn force-pushed the driessamyn/CORE-17623/move-token-selection-processor branch 3 times, most recently from 36ee75a to a16e340 Compare October 12, 2023 07:58
@driessamyn driessamyn mentioned this pull request Oct 12, 2023
Merged
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Oct 12, 2023 •
edited
Loading

Jenkins build for PR 4835 build 16

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1697110021514
Helm chart version produced by this PR: 5.1.0-alpha.1697110021514
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-4835/corda

@driessamyn driessamyn force-pushed the driessamyn/CORE-17623/move-token-selection-processor branch from 2dd3743 to b5df16a Compare October 12, 2023 11:26
@driessamyn driessamyn marked this pull request as ready for review October 12, 2023 11:26
@driessamyn driessamyn requested review from a team as code owners October 12, 2023 11:26
ronanbrowne
ronanbrowne approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@ronanbrowne ronanbrowne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - build

filipesoliveira
filipesoliveira approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@filipesoliveira filipesoliveira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@driessamyn driessamyn merged commit 5340472 into release/os/5.1 Oct 12, 2023
1 check passed
@driessamyn driessamyn deleted the driessamyn/CORE-17623/move-token-selection-processor branch October 12, 2023 13:58
lankydan pushed a commit that referenced this pull request Oct 13, 2023
@driessamyn @lankydan
CORE-17623 - move-token-selection-processor (#4835)
184ab2d 
Move the Token Selection Processor in the stand-alone worker.
driessamyn added a commit that referenced this pull request Oct 13, 2023
@driessamyn
CORE-17623 - move-token-selection-processor (#4835)
c544155 
Move the Token Selection Processor in the stand-alone worker.
@corda-jenkins-ci02 corda-jenkins-ci02 bot mentioned this pull request Oct 18, 2023
Merged
@corda-jenkins-ci02 corda-jenkins-ci02 bot mentioned this pull request Oct 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@filipesoliveira filipesoliveira filipesoliveira approved these changes

@ronanbrowne ronanbrowne ronanbrowne approved these changes

@owenstanford owenstanford Awaiting requested review from owenstanford

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@driessamyn @ronanbrowne @filipesoliveira