Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORE-18390: Allow old version of SetOwnRegistrationStatus in the command #5114

Merged
merged 2 commits into from
Nov 16, 2023

Conversation

yift-r3
Copy link
Contributor

@yift-r3 yift-r3 commented Nov 16, 2023

This should accept commands from a 5.0 cluster.

See the API pull request at corda/corda-api#1342

@yift-r3 yift-r3 changed the base branch from release/os/5.2 to release/os/5.1 November 16, 2023 13:03
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rule: 2-PEM-PRIVATE
SeverityCRITICAL
File: docs/kafka/security/demo/certificates/ca/ca-key
Lines: 1
Scanner: Secret Diver

More Info Contains a private key

@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Nov 16, 2023

Jenkins build for PR 5114 build 3

Build Successful:
Jar artifact version produced by this PR: 5.1.0.0-alpha-1700161725153
Helm chart version produced by this PR: 5.1.0-alpha.1700161725153
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-5114/corda

charlieR3
charlieR3 previously approved these changes Nov 16, 2023
@yift-r3 yift-r3 changed the title CORE-18357: Allow old version of SetOwnRegistrationStatus in the command CORE-18390: Allow old version of SetOwnRegistrationStatus in the command Nov 16, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@yift-r3 yift-r3 marked this pull request as ready for review November 16, 2023 19:08
@yift-r3 yift-r3 merged commit fb8ddad into release/os/5.1 Nov 16, 2023
2 checks passed
@yift-r3 yift-r3 deleted the yift/core-18357/allow-v1-in-command branch November 16, 2023 19:44
jujoramos pushed a commit to jujoramos/corda-runtime-os that referenced this pull request Nov 20, 2023
…and (corda#5114) (corda#5124)

* CORE-18357: Allow old version of SetOwnRegistrationStatus in the command

* Set to the correct version

Co-authored-by: Yiftach Kaplan <[email protected]>
Co-authored-by: Yiftach Kaplan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants