CORE-18414 Tests for MemberInfo serialization #5133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Jenkins build for PR 5133 build 5 Build Successful: |
charlieR3
reviewed
Nov 20, 2023
...p/membership-impl/src/test/kotlin/net/corda/membership/lib/impl/utils/MemberInfoTestUtils.kt
Outdated
Show resolved
Hide resolved
...p/membership-impl/src/test/kotlin/net/corda/membership/lib/impl/utils/MemberInfoTestUtils.kt
Outdated
Show resolved
Hide resolved
...p/membership-impl/src/test/kotlin/net/corda/membership/lib/impl/utils/MemberInfoTestUtils.kt
Outdated
Show resolved
Hide resolved
charlieR3
reviewed
Nov 20, 2023
...p/membership-impl/src/test/kotlin/net/corda/membership/lib/impl/utils/MemberInfoTestUtils.kt
Outdated
Show resolved
Hide resolved
charlieR3
previously approved these changes
Nov 20, 2023
YashNabar
force-pushed
the
yash/CORE-18414
branch
from
2a180a6 to
a2a9c26
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
charlieR3
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds unit testing around custom AMQP serializers added for
MemberContextandMGMContextas part of #5127.Also includes some refactoring around
MemberInfotest utilities.