Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DA5-22: Distribution and validation of draft transactions #5295

Conversation

julia-filipczak
Copy link
Contributor

@julia-filipczak julia-filipczak commented Dec 18, 2023

Implementing draft transaction send/receive UTXO ledger functionality
API pr: corda/corda-api#1413

https://r3-cev.atlassian.net/browse/DI-4

…idation-of-draft-transactions

# Conflicts:
#	components/ledger/ledger-utxo-flow/src/main/kotlin/net/corda/ledger/utxo/flow/impl/flows/backchain/TransactionBackchainExtensions.kt
#	gradle.properties
Copy link
Contributor

@vlajos vlajos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A description of the PR would be useful.
Also cross-linking the API/runtime-os PRs makes reviewing easier.

@julia-filipczak julia-filipczak marked this pull request as ready for review December 20, 2023 16:19
@julia-filipczak julia-filipczak requested a review from a team as a code owner December 20, 2023 16:19
julia-filipczak and others added 4 commits December 20, 2023 17:39
…alidation-of-draft-transactions' into juliaf/DA5-22-Distribution-and-Validation-of-draft-transactions
@corda-jenkins-ci02
Copy link
Contributor

corda-jenkins-ci02 bot commented Dec 20, 2023

Jenkins build for PR 5295 build 16

Build Successful:
Jar artifact version produced by this PR: 5.2.0.0-alpha-1704727422443
Helm chart version produced by this PR: 5.2.0-alpha.1704727422443
Helm chart pushed to: oci://corda-os-docker-dev.software.r3.com/helm-charts/pr-5295/corda

…idation-of-draft-transactions

# Conflicts:
#	components/ledger/ledger-utxo-flow/src/main/kotlin/net/corda/ledger/utxo/flow/impl/transaction/factory/impl/UtxoLedgerTransactionFactoryImpl.kt
#	gradle.properties
…idation-of-draft-transactions

# Conflicts:
#	gradle.properties
Copy link

github-actions bot commented Jan 5, 2024

This PR is stale because it has been open 7 days with no activity. Remove the Stale label or add a comment - otherwise this will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jan 5, 2024
vlajos
vlajos previously approved these changes Jan 8, 2024
blsemo
blsemo previously approved these changes Jan 8, 2024
Copy link
Contributor

@blsemo blsemo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@julia-filipczak julia-filipczak dismissed stale reviews from blsemo and vlajos via 580eaaa January 8, 2024 12:25
vlajos
vlajos previously approved these changes Jan 8, 2024
Copy link

sonarqubecloud bot commented Jan 8, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@julia-filipczak julia-filipczak merged commit e0697e1 into release/os/5.2 Jan 8, 2024
4 checks passed
@julia-filipczak julia-filipczak deleted the juliaf/DA5-22-Distribution-and-Validation-of-draft-transactions branch January 8, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants