Lts doc updates #178
Open
Lts doc updates #178
+74
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👌 thanks a lot! |
roastario
previously approved these changes
Feb 11, 2020
roastario
previously approved these changes
Feb 11, 2020
kasiastreich
previously approved these changes
Feb 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all - pls find some proposed changes to the LTS docs in t-sdk 1.1 based on some things we found using them.
Imagine you'll (quite correctly :-) ) take issue with the lateinit var and the horrific map example for tests. The latter i'm open to all suggestions. The former we did because we found that the LTS was used in deeply nested structures and as such passing it down the call hierarchy wasn't very nice. Though obviously nor is a var. Any thoughts?
Thanks again for this bit of work. Amazing to have a fast, threadsafe token selector.