Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module-loader): allow to abort module loading while stil loading #146

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

heymdall-legal
Copy link
Collaborator

Исправляем удаление ресурсов модуля со страницы. До этого если модуль отмонтировался со страницы до того как он загрузился - все его стили и скрипты остались бы на странице.
Теперь все удаляется как надо.

@changeset-bot
Copy link

changeset-bot bot commented Oct 13, 2023

🦋 Changeset detected

Latest commit: 92cb660

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@alfalab/scripts-modules Patch
example-modules Patch
example Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@heymdall-legal heymdall-legal marked this pull request as ready for review October 13, 2023 14:18
@heymdall-legal heymdall-legal merged commit 1d5758e into master Oct 16, 2023
3 checks passed
@heymdall-legal heymdall-legal deleted the fix/loading-abort branch October 16, 2023 12:13
@core-ds-bot core-ds-bot mentioned this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants