Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): add node@20 support, drop node@14 #179

Merged
merged 1 commit into from
Jan 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions .changeset/famous-windows-press.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
---
'arui-scripts': major
---

Прекращена поддержка nodejs@14.
Поддерживаемые версии nodejs: `16.20.2, 18.0.0+, 20.0.0+`.

Базовые образы `alpine-node-nginx` больше не будут публиковаться с тегом `latest`, он остается зафиксированным на версии `14.21.3`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

а разве не '16.20.2' фиксируется ниже?


Вы можете продолжать использовать `arui-scripts` с nodejs@14, но мы не будем исправлять ошибки, связанные с этой версией nodejs.
Совместимость peer зависимостей не гарантируется.
23 changes: 3 additions & 20 deletions .github/workflows/alpine-node.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,35 +10,18 @@ on:

env:
# version that would be tagged as latest
LATEST_VERSION: 14.21.3
LATEST_VERSION: 'dont use latest version' # Использование latest версии крайне не желательно, поскольку никак толком не контролирует как именно собирается проект

jobs:

# build node@14 with alpine 3.18
buildOldNode:
runs-on: ubuntu-latest
steps:
- name: Checkout code
uses: actions/checkout@v2

- name: Build and push Docker images
uses: docker/build-push-action@v1
with:
path: packages/alpine-node-nginx/node-14-alpine-3.18/
username: ${{ secrets.DOCKER_USERNAME }}
password: ${{ secrets.DOCKER_ACCESS_TOKEN }}
repository: alfabankui/nodejs
tags: 14.21.3-alpine3.18

build:
needs:
- buildOldNode
strategy:
matrix:
versions: [
{ node: 14.21.3, alpine: 3.18, image: alfabankui/nodejs },
{ node: 16.20.2, alpine: 3.18, image: node },
{ node: 18.18.2, alpine: 3.18, image: node },
{ node: 18.19.0, alpine: 3.19, image: node },
{ node: 20.11.0, alpine: 3.19, image: node },
]
runs-on: ubuntu-latest
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ jobs:

strategy:
matrix:
node-version: [14.x, 16.x, 18.x]
node-version: [16.x, 18.x, 20.x]

steps:
- uses: actions/checkout@v1
Expand Down
2 changes: 1 addition & 1 deletion packages/arui-scripts/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ ARUI-scripts

Зависимость | Версия
-- | --
`nodejs` | `14.21.3, 16.20.2, 18.0.0+`
`nodejs` | `16.20.2, 18.0.0+, 20.0.0+`
`react` | `16.13.0+`
`react-dom` | `16.13.0+`

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export function getDefaultAppConfig(): AppConfigs {

// docker compilation configs
dockerRegistry: '',
baseDockerImage: 'alfabankui/arui-scripts:latest',
baseDockerImage: 'alfabankui/arui-scripts:16.20.2',
nginxRootPath: '/src',
runFromNonRootUser: true,
removeDevDependenciesDuringDockerBuild: true,
Expand Down
Loading