feat(*): add useSwc option #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4a60f85 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
qrik116
approved these changes
Sep 25, 2024
amodanov
reviewed
Oct 2, 2024
| @@ -9,9 +9,10 @@ import config from '../../configs/webpack.client.prod'; | |||
| import { MultiStats } from 'webpack'; | |||
|
|
|||
| console.log(chalk.magenta('Building client...')); | |||
|
|
|||
| console.time('build client'); | |||
amodanov
reviewed
Oct 2, 2024
| @@ -18,6 +19,18 @@ if (configs.tsconfig) { | |||
| tsConfigPaths = tsConfig.config.compilerOptions.paths || {}; | |||
| } | |||
|
|
|||
| let tsxTransformer = require.resolve('./babel-transform'); | |||
There was a problem hiding this comment.
не очень люблю let в конфигах, предлагаю вынести условность определения tsxTransformer в метод, и сделать переменную константой
amodanov
approved these changes
Oct 2, 2024
NeoRu4
reviewed
Oct 9, 2024
| ].filter(Boolean), | ||
| }, | ||
| ...(configs.useSwcLoader | ||
| ? { |
There was a problem hiding this comment.
мб вынести это в отдельные переменные для swc и babel разные и будет просто красивый тернарник?
а то громоздко выглядит
NeoRu4
reviewed
Oct 9, 2024
| }, | ||
| ...(configs.useSwcLoader | ||
| ? { | ||
| loader: require.resolve('swc-loader'), |
heymdall-legal
force-pushed
the
feat/swc-loader
branch
from
92cd43f to
f1439ee
Compare
heymdall-legal
force-pushed
the
feat/swc-loader
branch
from
cdef412 to
4a60f85
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Добавлен флаг
useSwcдля использования swc-loader и swc-jest для транспиляции кода. Использование swc значительно ускоряет сборку (до 2 раз), без особых негативных последствий. Для большинства проектов миграция на swc будет абсолютно незаметна.swc так же поддерживает новый флаг
collectCoverage, для использования в e2e тулзах.Разница по размерам бандлов на реальных проектах оказывается минимальной, причем иногда при использовании br-сжатия даже в пользу swc.