Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Синхронизация b2am => b2n #15

Merged
merged 6 commits into from
Feb 20, 2024
Merged

Синхронизация b2am => b2n #15

merged 6 commits into from
Feb 20, 2024

Conversation

sashabull66
Copy link
Collaborator

@sashabull66 sashabull66 commented Feb 15, 2024 •
edited
Loading

  1. Убрано уже ненужное property defaultAmFeaturesFts из коструктора класса b2native и вся логика завязанная на работу с вышеуказанным свойством.
  2. Добавлен недостающий тест на метод b2native.closeWebview
  3. Невалидный метод reloadPage заменен на актуальный pseudoReloadPage
  4. Добавлен недостающий метод b2native.nativeNavigationAndTitle.handleNativeDeeplink
  5. Вынес класс b2n в отдельный файл а в файле index.ts реализовал импорт всего нужного (чтобы импорт был с одного уровня)

@sashabull66 sashabull66 changed the title Убрано свойство defaultAmFeaturesFts из коструктора Синхронизация b2am => b2n Feb 15, 2024
@puptup puptup self-requested a review February 20, 2024 07:38
@evgen-kent evgen-kent self-requested a review February 20, 2024 07:44
@sashabull66 sashabull66 merged commit 7a01c27 into main Feb 20, 2024
1 check passed
@sashabull66 sashabull66 deleted the feat/NEWCLICKUI-3078 branch February 20, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjswifty jjswifty jjswifty approved these changes

@andreitakarski andreitakarski andreitakarski approved these changes

@DavidGuryanov DavidGuryanov Awaiting requested review from DavidGuryanov DavidGuryanov is a code owner

@vahrammer vahrammer Awaiting requested review from vahrammer vahrammer is a code owner

@evgen-kent evgen-kent Awaiting requested review from evgen-kent evgen-kent is a code owner

@puptup puptup Awaiting requested review from puptup puptup is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@sashabull66 @andreitakarski @jjswifty @puptup @evgen-kent